Skip to content

Avoid discovery errors for inner classes not annotated with @Nested #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

marcphilipp
Copy link
Member

Overview

  • Fix StackOverflowError
  • Avoid discovery errors for inner classes not annotated with @Nested

Resolves #4661.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases seem to match the use-cases seen in the wild, implementation looks good too.

@marcphilipp marcphilipp merged commit 8738f1b into main Jun 24, 2025
14 checks passed
@marcphilipp marcphilipp deleted the marc/4661-avoid-overeager-discovery-errors branch June 24, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovery issue for cycle in inner class hierarchy without @Nested fails build since JUnit 5.13
2 participants