Skip to content

Compress images to improve download/upload speed #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

Seems to work and this one is faster than the regular build.

Scheduled build in main: 1h 54m 50s
This PR: 1h 24m 36s

It's easy to see, that docker save is just a bit slower, while upload/download might be a few minutes faster.

@mathbunnyru mathbunnyru merged commit 2df2eec into jupyter:main Jul 3, 2023
kentwait pushed a commit to kentwait/docker-stacks that referenced this pull request Aug 3, 2023
mathbunnyru added a commit to mathbunnyru/docker-stacks that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant