-
Notifications
You must be signed in to change notification settings - Fork 3k
Healthcheck gives correct result even behind proxy #1964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM and thank you for adding a test 👍
Use empty string instead of None Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
The tests that fail do not have anything to do with the test I added. Interestingly they seem to fail without the changes too? |
Let's hope it was a spurious fail. I restarted failed GitHub jobs. |
I guess the reason is that for some reason
|
@MatthiasJobst I fixed (actually, mitigated) the issue in the main branch and merged it here. |
Thanks. That was quick and solved the issue. |
Changes
For environments that use proxies, mostly corporate environments, the health check did not work. Proxies are not necessary for the health check so the proxies are disabled.
The health check runs in the docker container and makes a request to a specific address. If that request is routed through a proxy it leaves the docker container. This can cause two types of problems:
Issue ticket
Closed 1962
Checklist (especially for first-time contributors)