Do not compress images in actions/upload-artifact
#2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without compression: With compression: The difference in size is around 0.1%, which means compression doesn't make sense at all. And we get faster uploads. |
mathbunnyru
changed the title
actions/upload-artifact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We already use zst to compress our images, so it shouldn't be necessary to compress on upload.
https://github.com/actions/upload-artifact?tab=readme-ov-file#inputs
For large files that are not easily compressed, a value of 0 is recommended for significantly faster uploads.Issue ticket if applicable
Checklist (especially for first-time contributors)