making the Makefile checks serial #1409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable (and it was probably a bug, not just a cosmetic issue);
but can you rename all0 -> subdirs ?
…On Thu, Feb 9, 2017 at 9:56 AM, jtrmal ***@***.***> wrote:
@dogancan <https://github.com/dogancan> @danpovey
<https://github.com/danpovey> , what do you think about this?
The issue I'm trying address is that if make is run with -j, the output is
usually quite convoluted and is not directly obvious what is the error.
y.
------------------------------
You can view, comment on, or merge this pull request online at:
#1409
Commit Summary
- making the checks serial
File Changes
- *M* src/Makefile
<https://github.com/kaldi-asr/kaldi/pull/1409/files#diff-0> (10)
Patch Links:
- https://github.com/kaldi-asr/kaldi/pull/1409.patch
- https://github.com/kaldi-asr/kaldi/pull/1409.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1409>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADJVu0R3cTbkM8SXjp8E6G5oYYheGUD9ks5raykkgaJpZM4L8OmE>
.
|
|
ok, done. |
|
LGTM. |
david-ryan-snyder
pushed a commit
to david-ryan-snyder/kaldi
that referenced
this pull request
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dogancan @danpovey , what do you think about this?
The issue I'm trying address is that if make is run with -j, the output is usually quite convoluted and is not directly obvious what is the error.
y.