-
Notifications
You must be signed in to change notification settings - Fork 49
Fix(web): conditionally choose gnosis or chiado #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(web): conditionally choose gnosis or chiado #1646
Conversation
WalkthroughThe recent change to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-university ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Code Climate has analyzed commit 1b113dc and detected 0 issues on this pull request. View more on Code Climate. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/src/consts/chains.ts (1 hunks)
Additional comments not posted (1)
web/src/consts/chains.ts (1)
15-17
: Ensure correctness of dynamic selection logic.The dynamic selection logic for
QUERY_CHAINS
looks good and ensures that the appropriate chain is chosen based on the deployment environment.However, verify that the
isProductionDeployment()
function is correctly defined and functioning as expected.Verification successful
Ensure correctness of dynamic selection logic.
The dynamic selection logic for
QUERY_CHAINS
looks good and ensures that the appropriate chain is chosen based on the deployment environment. TheisProductionDeployment
function is correctly defined in multiple places to check theREACT_APP_DEPLOYMENT
environment variable.
web/src/consts/processEnvConsts.ts
web/src/consts/index.ts
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definition and functionality of the `isProductionDeployment` function. # Test: Search for the function definition. Expect: Only occurances of the function definition. rg --type-add 'ts' --files-with-matches 'isProductionDeployment' | xargs rg 'function isProductionDeployment'Length of output: 167
Script:
#!/bin/bash # Description: Verify the definition and functionality of the `isProductionDeployment` function. # Corrected command to search for the function definition in TypeScript files. rg 'function isProductionDeployment' --glob '*.ts'Length of output: 52
Script:
#!/bin/bash # Description: Verify the definition and functionality of the `isProductionDeployment` function. # Search for various possible definitions of the `isProductionDeployment` function. rg 'isProductionDeployment' --glob '*.ts'Length of output: 1429
PR-Codex overview
This PR updates the
QUERY_CHAINS
constant inchains.ts
to dynamically select the chain based on the production deployment status.Detailed summary
QUERY_CHAINS
constant inchains.ts
.Summary by CodeRabbit
gnosis
andgnosisChiado
based on the deployment environment.