feat(pop-up): refactoring KbqPopUpTrigger, KbqPopUp (#DS-2852) #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0f960a6): https://koobiq-next--prs-260-hn28v3jw.web.app (expires Wed, 11 Sep 2024 11:56:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
artembelik
reviewed
Sep 6, 2024
artembelik
reviewed
Sep 6, 2024
packages/components/ellipsis-center/ellipsis-center.directive.ts
Outdated
Show resolved
Hide resolved
artembelik
reviewed
Sep 6, 2024
artembelik
approved these changes
Sep 6, 2024
NikGurev
approved these changes
Sep 6, 2024
sk8knut
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В KbqPopUp и KbqPopUpTrigger можно использовать inject для параметров, которые сейчас передаются в конструкторе (overlay, elementRef, ngZone, scrollDispatcher, hostView, scrollStrategy, direction).
Это позволит избежать передачу большого количества параметров при наследовании в:
KbqPasswordToggle
KbqPopoverConfirmTrigger
KbqPopoverTrigger
KbqOptionTooltip
KbqTooltipTrigger
KbqWarningTooltipTrigger
KbqExtendedTooltipTrigger
KbqTitleDirective
KbqEllipsisCenterDirective
KbqNavbarItem
KbqNavbarToggle
KbqTimezoneOptionTooltip
Так же из applyPopupMargins убрал inject(Renderer2), теперь он передается аргументом.