Skip to content

feat(docs): added "new" section badge in sidenav (#DS-3386) #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2025

Conversation

NikGurev
Copy link
Contributor

@NikGurev NikGurev commented Apr 17, 2025

Summary

Добавил бейдж и логику скрытия через время (expirationDate), чтобы неактуальные бейджи не отображались.

@NikGurev NikGurev added the documentation Improvements or additions to documentation label Apr 17, 2025
@NikGurev NikGurev self-assigned this Apr 17, 2025
Copy link

github-actions bot commented Apr 17, 2025

Visit the preview URL for this PR (updated for commit 8aa65a5):

https://koobiq-next--prs-662-ccht1fmw.web.app

(expires Wed, 23 Apr 2025 10:23:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik
Copy link
Contributor

artembelik commented Apr 17, 2025

мб упростим это все, и будем управлять элементами навигации из одного места (apps/docs/src/app/services/documentation-items.ts), чтото типа такого:

import { DateTime } from 'luxon';

{
  id: 'core',
  ...
  isNew: DateTime.now().diff(DateTime.fromISO('2025-04-17'), 'days') < N, // N = 30? 
}

по поводу CI не уверен, нужно нам или нет, пока сложно сказать

@NikGurev NikGurev requested a review from lskramarov April 17, 2025 14:29
@NikGurev
Copy link
Contributor Author

NikGurev commented Apr 18, 2025

мб упростим это все, и будем управлять элементами навигации из одного места (apps/docs/src/app/services/documentation-items.ts), чтото типа такого:

import { DateTime } from 'luxon';

{
  id: 'core',
  ...
  isNew: DateTime.now().diff(DateTime.fromISO('2025-04-17'), 'days') < N, // N = 30? 
}

по поводу CI не уверен, нужно нам или нет, пока сложно сказать

@artembelik вынес в функцию expiresAt, чтобы в объекте была только дата, а "магия" оставалась в функции

@artembelik
Copy link
Contributor

@rmnturov actions panel, breadcrumbs и тд уже не считаем за new?

@NikGurev NikGurev merged commit 4fa9063 into main Apr 18, 2025
3 checks passed
@NikGurev NikGurev deleted the feat/DS-3386 branch April 18, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants