fix(file-upload): corrected file add emit on click (#DS-3451) #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 21fcb34): https://koobiq-next--prs-706-3pz0jslr.web.app (expires Sun, 04 May 2025 13:13:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
Почему называние ветки hotfix ? |
lskramarov
reviewed
Apr 28, 2025
packages/components/file-upload/single-file-upload.component.ts
Outdated
Show resolved
Hide resolved
баг возник после фикса другого бага, задачи на это не было, но решил , что нужно поправить как можно скорее |
есть bugfix не нужно придумывать новое. По хорошему нужно переоткрыть баг и указать в PR |
NikGurev
changed the title
lskramarov
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed bug introduced by #682