Skip to content

style: enable all angular eslint rules (#DS-2920) #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025
Merged

Conversation

artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik changed the title style: update comment eslint plugin and enable all ng template rules … style: update comment eslint plugin and enable all ng template rules (#DS-2920) May 15, 2025
Copy link

github-actions bot commented May 15, 2025

Visit the preview URL for this PR (updated for commit 2544cc6):

https://koobiq-next--prs-732-esrg31ab.web.app

(expires Sat, 24 May 2025 14:21:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik marked this pull request as draft May 16, 2025 07:11
@artembelik artembelik self-assigned this May 16, 2025
@artembelik artembelik marked this pull request as ready for review May 16, 2025 09:52
@artembelik artembelik changed the title style: update comment eslint plugin and enable all ng template rules (#DS-2920) style: enable all angular eslint rules (#DS-2920) May 16, 2025
@NikGurev
Copy link
Contributor

Появилось после применения правил

Warning: apps/docs/src/app/components/navbar/navbar.template.html:12:45 - warning NG8107: The left side of this optional chain operation does not include 'null' or 'undefined' in its type, therefore the '?.' operator can be replaced with the '.' operator.

12                 {{ docStates.currentHeader?.textContent }}
                                               ~~~~~~~~~~~

  apps/docs/src/app/components/navbar/navbar.component.ts:32:18
    32     templateUrl: 'navbar.template.html',
                        ~~~~~~~~~~~~~~~~~~~~~~
    Error occurs in the template of component DocsNavbarComponent.

@artembelik
Copy link
Contributor Author

Появилось после применения правил

Warning: apps/docs/src/app/components/navbar/navbar.template.html:12:45 - warning NG8107: The left side of this optional chain operation does not include 'null' or 'undefined' in its type, therefore the '?.' operator can be replaced with the '.' operator.

12                 {{ docStates.currentHeader?.textContent }}
                                               ~~~~~~~~~~~

  apps/docs/src/app/components/navbar/navbar.component.ts:32:18
    32     templateUrl: 'navbar.template.html',
                        ~~~~~~~~~~~~~~~~~~~~~~
    Error occurs in the template of component DocsNavbarComponent.

это предупреждение выдает tsconfig, а не eslint
видимо появилась после включения - strictTemplates
поправлю

@artembelik artembelik merged commit 3650502 into main May 19, 2025
3 checks passed
@artembelik artembelik deleted the style/eslint branch May 19, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants