Skip to content

fix(file-upload): synced file type validation (#DS-3331) #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2025

Conversation

NikGurev
Copy link
Contributor

@NikGurev NikGurev commented Jun 16, 2025

Summary

  1. Made files in file-upload always loadable. No checks internally.
  2. Instead, provided new FileValidators.isCorrectExtension method and made validation external.
  3. Added unit-tests and doc examples

@NikGurev NikGurev self-assigned this Jun 16, 2025
@NikGurev NikGurev marked this pull request as ready for review June 17, 2025 15:43
@NikGurev NikGurev requested a review from lskramarov as a code owner June 17, 2025 15:43
@NikGurev NikGurev requested review from artembelik and rmnturov June 17, 2025 15:43
Copy link

github-actions bot commented Jun 17, 2025

Visit the preview URL for this PR (updated for commit 5dd56fb):

https://koobiq-next--prs-848-s54dd77i.web.app

(expires Tue, 24 Jun 2025 10:59:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@NikGurev NikGurev merged commit 7fa8ab6 into main Jun 19, 2025
5 checks passed
@NikGurev NikGurev deleted the bugfix/DS-3331 branch June 19, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants