-
Notifications
You must be signed in to change notification settings - Fork 595
feat: add message to ProgressNotification #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes include adding an optional message element to progress notifications. In the example code, a new key-value pair is added to the notification map that formats the progress percentage. Additionally, the progress notification structure is updated to include a new optional Changes
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@ezynda3 Hello, looks like all the checks have passed. Could you please review/merge this? |
Hello. I noticed that the 3.26 version specification added a message field for progress updates. However, I couldn’t find it in the current Golang SDK. This PR added an optional message field to ProgressNotificationParams according to latest mcp spec.
It's helpful for #77
I have verified the change with MCP Inspector. It works fine.
Summary by CodeRabbit
Summary by CodeRabbit