refactor: rename DummyProcess to FallbackProcess in Windows stdio #1015
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
pushed a commit
that referenced
this pull request
Jun 24, 2025
Merging, rename for `DummyProcess` -> `FallbackProcess` coming in #1015
More descriptive name that better reflects its purpose as a fallback implementation for Windows subprocess handling when asyncio support is unavailable.
felixweinberger
force-pushed
the
fweinberger/rename-dummy-to-fallback-process
branch
from
4e13639 to
d5fa7b9
Compare
felixweinberger
requested review from
ihrpr
and removed request for
jspahrsummers,
jerome3o-anthropic and
ihrpr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DummyProcesstoFallbackProcessfor better clarityContext
This builds on #596 which fixes Windows subprocess compatibility. The rename was requested to better communicate that this is a fallback mechanism used when the standard async subprocess support is unavailable on Windows.
Test plan