-
Notifications
You must be signed in to change notification settings - Fork 208
Update installation instruction to use pie
#1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Install the [`mongodb/mongodb-extension`](https://packagist.org/packages/mongodb/mongodb-extension) package from Packagist using the following command: | ||
|
||
```shell | ||
pie install mongodb/mongodb-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add an example on how to use version constraints - we could show how to install version 2.1 or newer:
pie install "mongodb/mongodb-extension:^2.1"
README.md
Outdated
@@ -40,7 +58,7 @@ distributed as the | |||
[`mongodb/mongodb`](https://packagist.org/packages/mongodb/mongodb) package for | |||
[Composer](https://getcomposer.org). | |||
|
|||
## Release Integrity | |||
### Release Integrity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release integrity is relevant even when not installing with PECL, and moving it to a sub-header doesn't make sense IMO. We can add a general "Installation" header above and make the sections for pie and pecl sub-sections of that installation section.
Since pie doesn't support signature verification and also doesn't support installing from a downloaded binary, we should add a note that integrity validation is not yet supported with pie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title updated.
Note added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
pie 1.0.0 has been released, it's the new recommended way of installing PHP extension as it works with Windows, Linux and Mac. It provides more security as the extension metadata are extracted from GitHub releases and published on Packagist
mongodb/mongodb-extension
, and the source are downloaded from GitHub releases.