Skip to content

Update installation instruction to use pie #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 19, 2025

pie 1.0.0 has been released, it's the new recommended way of installing PHP extension as it works with Windows, Linux and Mac. It provides more security as the extension metadata are extracted from GitHub releases and published on Packagist mongodb/mongodb-extension, and the source are downloaded from GitHub releases.

@GromNaN GromNaN requested a review from a team as a code owner June 19, 2025 16:01
@GromNaN GromNaN requested review from paulinevos and alcaeus and removed request for a team June 19, 2025 16:01
Install the [`mongodb/mongodb-extension`](https://packagist.org/packages/mongodb/mongodb-extension) package from Packagist using the following command:

```shell
pie install mongodb/mongodb-extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an example on how to use version constraints - we could show how to install version 2.1 or newer:

pie install "mongodb/mongodb-extension:^2.1"

README.md Outdated
@@ -40,7 +58,7 @@ distributed as the
[`mongodb/mongodb`](https://packagist.org/packages/mongodb/mongodb) package for
[Composer](https://getcomposer.org).

## Release Integrity
### Release Integrity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release integrity is relevant even when not installing with PECL, and moving it to a sub-header doesn't make sense IMO. We can add a general "Installation" header above and make the sections for pie and pecl sub-sections of that installation section.

Since pie doesn't support signature verification and also doesn't support installing from a downloaded binary, we should add a note that integrity validation is not yet supported with pie.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title updated.
Note added.

@GromNaN GromNaN requested a review from alcaeus June 23, 2025 12:41
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@GromNaN GromNaN merged commit b58783c into mongodb:v2.x Jun 23, 2025
61 checks passed
@GromNaN GromNaN deleted the pie branch June 23, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants