RUST-1992 Driver changes to track bson serde-optional API changes #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Jun 18, 2025
| use crate::bson::RawBson; | ||
|
|
||
| pub(crate) trait RawDocumentBufExt: Sized { | ||
| fn append_err(&mut self, key: impl AsRef<str>, value: impl Into<RawBson>) -> RawResult<()>; |
There was a problem hiding this comment.
Since append and similar are now fallible in 3.0, the compatibility layer needed to make them fallible (at least at the type level) for 2.x as well, even if they never actually fail. The other option would be to wrap the 3.x variants in expect but this way people opting in to bson-3 get nicer error behavior as a bonus :)
| } | ||
| } | ||
|
|
||
| macro_rules! use_either { |
There was a problem hiding this comment.
I know this is kind of a frivolous use of a macro but I got real tired of writing these out by hand and I find the tabular format a lot easier to read. I can revert if you feel strongly :)
isabelatkinson
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1992
An awful lot of search and replace here; the only real substance is in the
bson_compatmodule.