-
Notifications
You must be signed in to change notification settings - Fork 2k
Added SNI support for JWT secrets retrieved from HTTPS URL #7500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabriziofiorucci
wants to merge
12
commits into
nginx:main
Choose a base branch
from
fabriziofiorucci:ff20250312
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−0
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e83f76a
NGINX App Protect DoS references added
fabriziofiorucci 280dedb
Merge branch 'nginxinc:main' into main
fabriziofiorucci f70bfe4
Added missing cd command
fabriziofiorucci 1b867e3
Added SNI support for JWT secrets retrieved from HTTPS URL
fabriziofiorucci 83ab922
Removed docs references
fabriziofiorucci 211d861
Merge branch 'main' into ff20250312
fabriziofiorucci 5cfc83f
Merge branch 'main' into ff20250312
jjngx f430a44
Merge branch 'main' into ff20250312
fabriziofiorucci d02dc74
branch updated
fabriziofiorucci 470ece5
Merge branch 'main' into ff20250312
fabriziofiorucci 6fd03bc
Merge branch 'main' into ff20250312
fabriziofiorucci d38955e
Merge branch 'main' into ff20250312
fabriziofiorucci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed. By default the value of
proxy_ssl_name
is the host part of theproxy_pass
URL, which is defined 4 lines later.I've asked about the port part of the URL though, so we might still need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this probably isn't needed. Could be moved to be after the line
set $idp_backend
with the valueproxy_ssl_name $idp_backend