Migration to JDK 17 #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,30 +9,23 @@ | |||
| <packaging>jar</packaging> | |||
|
|
|||
| <name>springboot-jwt</name> | |||
| <description>Demo project for Spring Boot</description> | |||
| <description>Spring Boot JWT Demo</description> | |||
There was a problem hiding this comment.
nit: should not have made this change
|
|
||
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>2.0.4.RELEASE</version> | ||
| <version>3.1.0</version> |
There was a problem hiding this comment.
I'm not sure about this one. But need to check what section represents here
| <relativePath/> <!-- lookup parent from repository --> | ||
| </parent> | ||
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <java.version>1.8</java.version> | ||
| <tomcat.port>9081</tomcat.port> |
There was a problem hiding this comment.
removing tomcat config seems wrong
| <java.version>1.8</java.version> | ||
| <tomcat.port>9081</tomcat.port> | ||
| <tomcat.ip>127.0.0.1</tomcat.ip> | ||
| <file>readme</file> |
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-oauth2-authorization-server</artifactId> |
There was a problem hiding this comment.
probably dependency version should be specified. But you can argue it was not specified for other dependencies as well. Maybe it's fine.
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <optional>true</optional> |
| </executions> | ||
| </plugin> | ||
|
|
||
| <plugin> |
There was a problem hiding this comment.
removing this entire section seems wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.