Fix critical tracing module issues and improve reliability #962
+138
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Typecheck Fixes: • Explicitly export set_trace_provider/get_trace_provider in __all__ to resolve mypy errors. • Add DefaultTraceProvider to __all__ for consistency. 2. Reliability Improvements: • Prevent crashes when custom providers lack a shutdown() method (via hasattr check). • Raise clear RuntimeError for invalid AGENT_TRACE_PROVIDER values instead of silently falling back. 3. Code Quality: • Reordered imports for PEP8 compliance and readability. • Simplified error handling in provider initialization. 4. Documentation: • Updated logging to use logging.debug for success messages and logging.warning for failures.
|
Looks duplicate of #957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typecheck Fixes:
• Explicitly export set_trace_provider/get_trace_provider in all to resolve mypy errors.
• Add DefaultTraceProvider to all for consistency.
Reliability Improvements:
• Prevent crashes when custom providers lack a shutdown() method (via hasattr check).
• Raise clear RuntimeError for invalid AGENT_TRACE_PROVIDER values instead of silently falling back.
Code Quality:
• Reordered imports for PEP8 compliance and readability.
• Simplified error handling in provider initialization.
Documentation:
• Updated logging to use logging.debug for success messages and logging.warning for failures.