refactor docs #1301
refactor docs #1301
Conversation
|
The changes look good, thanks! I've edited the PR description to describe them. Per the contributing guide, these changes should be made in the 3.1.x branch: |
|
Thank you, I see you've already change the branch to 3.1.x, what else do I need to do for merging the PR? @pamelafox |
|
It's confused since your branch still has all the main changes in it, can you replay your changes against 3.1? (Or rebase?) |
|
You need to |
docs/pagination.rst
Outdated
| {{ pagination.first }} - {{ pagination.last }} of {{ pagination.total }} | ||
| </div> | ||
| <div class=pagination> | ||
| <div class="pagination"> |
There was a problem hiding this comment.
This change is not needed, undo this.
There was a problem hiding this comment.
Why it's not needed? It should be the class name.
There was a problem hiding this comment.
quotes are optional for attributes without spaces in the value
There was a problem hiding this comment.
Didn't konw that, but it's best practice to not do that, right?
|
Is it ok to merge the PR now? |
|
Please review @davidism |
|
No need to ping me, a maintainer will review when they have time. |
This PR made some code improvements in docs: