Skip to content

feat(command): Add info command and simplify search output #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

niechen
Copy link
Contributor

@niechen niechen commented Apr 17, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 11:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new "info" command for displaying comprehensive details about MCP servers and updates the search command to use a table view instead of a detailed view. Key changes include:

  • Updating test expectations in tests for search output string changes (e.g., "Server One" → "server1").
  • Adding tests and implementation for the new "info" command with comprehensive output.
  • Refactoring the search command to replace the "--detailed" flag with a "--table" option and adding a simple servers list display.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_search.py Updated expected output strings and renaming tests to use table view
tests/test_info.py New tests for the info command functionality
src/mcpm/utils/display.py Added print_simple_servers_list function for simplified output
src/mcpm/commands/search.py Replaced detailed view with table and simple list views in search command
src/mcpm/commands/info.py Added implementation for the info command and its detailed output
src/mcpm/cli.py Registered the info command in the CLI
Comments suppressed due to low confidence (2)

tests/test_search.py:38

  • [nitpick] Ensure that the updated server naming convention ('server1') is consistently applied across the test outputs and documentation.
assert "server1" in result.output

tests/test_search.py:67

  • [nitpick] Confirm that changing the expected output from 'GitHub Server' to 'github-server' aligns with the intended naming scheme across the project.
assert "github-server" in result.output

Copy link
Contributor

Semantic Version Check

⚠️ No semantic version changes detected.

Please ensure your commits follow the Conventional Commits format:

  • feat: new feature (triggers MINOR version bump)
  • fix: bug fix (triggers PATCH version bump)
  • BREAKING CHANGE: description (triggers MAJOR version bump)

Copy link
Contributor

Semantic Version Check

⚠️ No semantic version changes detected.

Please ensure your commits follow the Conventional Commits format:

  • feat: new feature (triggers MINOR version bump)
  • fix: bug fix (triggers PATCH version bump)
  • BREAKING CHANGE: description (triggers MAJOR version bump)

@niechen niechen linked an issue Apr 17, 2025 that may be closed by this pull request
Copy link
Contributor

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 27a4443 Apr 17, 2025
7 checks passed
@JoJoJoJoJoJoJo JoJoJoJoJoJoJo deleted the 72-general-add-mcpm-info-command-to-show-individual-server-details branch April 17, 2025 11:48
mcpm-semantic-release bot pushed a commit that referenced this pull request Apr 17, 2025
# [1.2.0](v1.1.2...v1.2.0) (2025-04-17)

### Features

* **command:** Add info command and simplify search output ([#73](#73)) ([27a4443](27a4443))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General]: Add mcpm info command to show individual server details
2 participants