Skip to content

Fix OSS-Fuzz #427814452 #18965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Zend/tests/pipe_operator/oss_fuzz_427814452.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
--TEST--
OSS-Fuzz #427814452
--FILE--
<?php

try {
false |> assert(...);
} catch (\AssertionError $e) {
echo $e::class, ": '", $e->getMessage(), "'\n";
}
try {
0 |> "assert"(...);
} catch (\AssertionError $e) {
echo $e::class, ": '", $e->getMessage(), "'\n";
}
try {
false |> ("a"."ssert")(...);
} catch (\AssertionError $e) {
echo $e::class, ": '", $e->getMessage(), "'\n";
}

?>
--EXPECT--
AssertionError: ''
AssertionError: ''
AssertionError: ''
17 changes: 16 additions & 1 deletion Zend/zend_compile.c
Original file line number Diff line number Diff line change
Expand Up @@ -6426,6 +6426,20 @@ static bool can_match_use_jumptable(zend_ast_list *arms) {
return 1;
}

static bool zend_is_deopt_pipe_name(zend_ast *ast)
{
if (ast->kind != ZEND_AST_ZVAL || Z_TYPE_P(zend_ast_get_zval(ast)) != IS_STRING) {
return false;
}

/* Assert compilation adds a message operand, but this is incompatible with the
* pipe optimization that uses a temporary znode for the reference elimination.
* Therefore, disable the optimization for assert.
* Note that "assert" as a name is always treated as fully qualified. */
zend_string *str = zend_ast_get_str(ast);
return zend_string_equals_literal_ci(str, "assert");
}

static void zend_compile_pipe(znode *result, zend_ast *ast)
{
zend_ast *operand_ast = ast->child[0];
Expand Down Expand Up @@ -6453,7 +6467,8 @@ static void zend_compile_pipe(znode *result, zend_ast *ast)

/* Turn $foo |> bar(...) into bar($foo). */
if (callable_ast->kind == ZEND_AST_CALL
&& callable_ast->child[1]->kind == ZEND_AST_CALLABLE_CONVERT) {
&& callable_ast->child[1]->kind == ZEND_AST_CALLABLE_CONVERT
&& !zend_is_deopt_pipe_name(callable_ast->child[0])) {
fcall_ast = zend_ast_create(ZEND_AST_CALL,
callable_ast->child[0], arg_list_ast);
/* Turn $foo |> bar::baz(...) into bar::baz($foo). */
Expand Down