Skip to content

curl: Remove incorrect string release #18989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

curl: Remove incorrect string release #18989

wants to merge 1 commit into from
+0 −1

Conversation

nielsdos
Copy link
Member

The string is owned by the caller, and the caller releases it.

@nielsdos
curl: Remove incorrect string release
93b6c2f 
The string is owned by the caller, and the caller releases it.
@nielsdos nielsdos requested a review from adoy as a code owner June 30, 2025 22:45
Girgias
Girgias approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not possible to mark the zend_string parameter as const?

@nielsdos
Copy link
Member Author

nielsdos commented Jul 1, 2025

I guess it's not possible to mark the zend_string parameter as const?

Didn't try

@nielsdos nielsdos closed this in 11ea995 Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Labels
Extension: curl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias