Perception caching updates #2649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
Dec 13, 2023
stephencelis
added a commit
that referenced
this pull request
Jan 27, 2024
* bring back view store performance * wip * Allow chaining of store bindings * wip * Localize ignoring bindings to text field resignation/dismissal * wip * fix DiagnosticsError message (#2597) * store collection * wip * wip * update migration guide * Add `@Presents` macro for observable presentation While it would be nice for the `@PresentationState` property wrapper to "just work" with TCA's upcoming observable tools, sadly that does not seem to be the case. Adding observation directly to `@PresentationState`, as we have done with the beta so far, can break existing projects due to the additional observation. This primarily manifests itself in projects that present navigation stacks, where the `@PresentationState` observation can cause the navigation hierarchy to recompute and trigger SwiftUI bugs. The best we've come up with so far is introducing a brand new macro that automatically wraps a property with `@PresentationState` _and_ instruments it with observation. We're open to other ideas, and we do have future plans to eliminate the need for a property wrapper or macro at all, but till then this offers a non-breaking upgrade path! * fixes * Observe child store changes * wip * wip * wip * Fix typo in MigratingTo1.6.md (#2608) * Rename bindingViewStore argument to store in MigratingTo1.6.md (#2611) * wip * Revert "wip" This reverts commit f221ed0. * Add `@Presents` macro for observable presentation (#2604) * Add `@Presents` macro for observable presentation While it would be nice for the `@PresentationState` property wrapper to "just work" with TCA's upcoming observable tools, sadly that does not seem to be the case. Adding observation directly to `@PresentationState`, as we have done with the beta so far, can break existing projects due to the additional observation. This primarily manifests itself in projects that present navigation stacks, where the `@PresentationState` observation can cause the navigation hierarchy to recompute and trigger SwiftUI bugs. The best we've come up with so far is introducing a brand new macro that automatically wraps a property with `@PresentationState` _and_ instruments it with observation. We're open to other ideas, and we do have future plans to eliminate the need for a property wrapper or macro at all, but till then this offers a non-breaking upgrade path! * wip * Fix perception bindings (#2609) * Fix runtime warning when binding accesses perceptible state. * Fix runtime warning in SwiftUI bindings. * wip * wip * wip * wip * wip * wip * wip * wip --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * wip * wip * fix * wip * wip * wip * Check observable state identity for presentation state. * Add willSset/didSet to registrar types. * clean up @presents * clean up * fix * Emit observation warnings in escaping contexts like `ForEach` and `sheet` (#2613) * Fix perception warning in ForEach. * fix --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> * Introduce @ViewAction(for:) macro. (#2612) * Add back @ViewAction macro. * wip * wip * wip * wip * wip * clean up * wip * wip * fix migration guide' * ViewActionable * wip * rename * wip * wip --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * Introduce @BindableStore for bindings in pre-iOS 17 (#2610) * Introduce @BindableStore. * docs * wip * wip * fixc * wip * wip * wip * wip --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * re-record intergration logs * wip * wip * localize invalid stores to store collection * Deprecate closure-based `store.scope` operations (#2618) These uncached operations can be problematic, especially when working with observation, which often depends on the stable identity of stores. * document * Update warning message * Performance Improvement: Skip perception checks when calling reducers. (#2622) * Skip perception checks when calling reducers. * inline withoutPerceptionChecking() for RELEASE Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> --------- Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> * Don't show perception warnings in action closures. (#2614) * Don't show perception warnings in action closures. * wip * wip * wip * clean up * wip --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * fix BindableStore + release * Add docs * Change associated type names of ViewActionSending (#2629) * Fix some @ViewAction annoyances. * wip * wip * wip * wip * wip * wip * fix * wip * fixed merge * Add new view modifiers for observing alerts/dialogs (#2628) * Add new view modifiers for observing alerts/dialogs Instead of: ```swift .alert(store: store.scope(state: \.$alert, action: \.alert)) ``` You can now do: ```swift .alert($store.scope(state: \.alert, action: \.alert)) ``` This new modifier is powered by the same store binding scope operation that can power `sheet(item:)`, etc., and is much lighter weight than the previous view modifier, which spun up view stores and `WithViewStore` views. * wip * wip * wip --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> * Fix uncached warning when using Store.ifLet (#2625) * Fix uncached warning when using Store.ifLet * wip * wip * wip * wip * wip * wip --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * Resolve packages * Updated scopes * wip * wip * updated binding docs * adding docs * clean up * wip * wip * wip * clean up * clean up * clean up * wip; * lots of fixes * update more docs * fix * wip * wip * Remove ObservationRegistrarWrapper. (#2634) * Remove ObservationRegistrarWrapper. * Delete Sources/ComposableArchitecture/Internal/ObservationRegistrarWrapper.swift --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * more docs * update docs * a few more tests * fix * wip * wip * wip * Cache data in store collections (#2635) * fix tutorial highlighting * wip * wip * wip * wip * tests for observation of special domain types * another test * fix * wip * Implement memoization for perception checks (#2630) * Implement memoization for isInSwiftUIBody * tidy up * Perception caching updates (#2649) * Small updates to perception caching. * wip * debug * some more macro tests * syncups tutorial beginnings * wip * wip * wip * wip * wip * merge fixes * wip * update tests * fix * fix * fix perception checking in store * rename task local * delete old test * deprecate test using old apis * fix test * perception tests for store * wip * wip * wip * wip * wip * wip * wip * Opt out of key path for Store.ifLet * sync ups * lots more sync up tutorial * more sync ups tutorial * wip * wip * wio * wip * wip * wip * updated references of 1.6 to 1.7 * wip * no need to force unwrap here * fixed crash in ForEach with bindings * more sync ups tutorial * more sync ups tutorial * wip * more sync ups * wip * wip * Better support for observing copies of values (#2650) * Explore using _modify * wip * wip * wip * wip * wip * wip * more tests * wip * get another failing test for an edge case * wip * tests all passing * flag for determining when new state was created * wip * clean up * wip * wip * wip; * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * New test that currently fails. * wip * wip * Update Sources/ComposableArchitectureMacros/PresentsMacro.swift * wip * remove redundant attached member attribute * storage * cleanup * more benchmarks and tests * wip * wip * wip * wip * update tests * wip * wip --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> * wip * wip * wip * swift-format * fix * wip * wip * wip * wip * Perception * wip * wip * clean up shared state * fix shared state tests * wip * add alert test * wip * wip * wip * wip * Use transaction in binding * wip * wip * wip * wip * wip * wip * uikit * keep references to controllers when presenting so that we can properly dismiss * change order of features in shared state demo * wip * cleanup * cleanup * wip * wip * wip * Fix perception checking for effect actions. * wip * wip * wip * Fix perception checking for effect actions. * wip * wip * remove sync ups tutorial * wip * wip * wip * wip * wip * docs for observe function for uikit * Add cancellation to observation' * re-record integration test snapshots * fixed some todos * update test * remove 5.9.2 checks * wip * improve docs * update docs * updates * lots of fixes * more docs * remove unneeded file; * wip * wip * wip * update readme and getting started * wip * simplify * migration stuff * wip * Update Models.swift * wip * wip * wip * Update Bindings.md * wip * wip * wip * wip * fix * wip * wip * wip * wip * wip Co-authored-by: Kabir Oberai <oberai.kabir@gmail.com> --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> Co-authored-by: hmhv <admin@hmhv.info> Co-authored-by: Jimmy Prime <jimmylevelup@gmail.com> Co-authored-by: Michael Pohl <15653162+Mika5652@users.noreply.github.com> Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> Co-authored-by: George Scott <gscott@gekkoto.com> Co-authored-by: Kabir Oberai <oberai.kabir@gmail.com>
stephencelis
added a commit
that referenced
this pull request
Feb 12, 2024
* updated binding docs * adding docs * clean up * wip * wip * wip * clean up * clean up * clean up * wip; * lots of fixes * update more docs * fix * wip * wip * Remove ObservationRegistrarWrapper. (#2634) * Remove ObservationRegistrarWrapper. * Delete Sources/ComposableArchitecture/Internal/ObservationRegistrarWrapper.swift --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> * more docs * update docs * a few more tests * fix * wip * wip * wip * Cache data in store collections (#2635) * fix tutorial highlighting * wip * wip * wip * wip * tests for observation of special domain types * another test * fix * wip * Implement memoization for perception checks (#2630) * Implement memoization for isInSwiftUIBody * tidy up * Perception caching updates (#2649) * Small updates to perception caching. * wip * debug * some more macro tests * syncups tutorial beginnings * wip * wip * wip * wip * wip * merge fixes * wip * update tests * fix * fix * fix perception checking in store * rename task local * delete old test * deprecate test using old apis * fix test * perception tests for store * wip * wip * wip * wip * wip * wip * wip * Opt out of key path for Store.ifLet * sync ups * lots more sync up tutorial * more sync ups tutorial * wip * wip * wio * wip * wip * wip * updated references of 1.6 to 1.7 * wip * no need to force unwrap here * fixed crash in ForEach with bindings * more sync ups tutorial * more sync ups tutorial * wip * more sync ups * wip * wip * Better support for observing copies of values (#2650) * Explore using _modify * wip * wip * wip * wip * wip * wip * more tests * wip * get another failing test for an edge case * wip * tests all passing * flag for determining when new state was created * wip * clean up * wip * wip * wip; * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * New test that currently fails. * wip * wip * Update Sources/ComposableArchitectureMacros/PresentsMacro.swift * wip * remove redundant attached member attribute * storage * cleanup * more benchmarks and tests * wip * wip * wip * wip * update tests * wip * wip --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> * wip * wip * wip * swift-format * fix * wip * wip * wip * wip * Perception * wip * wip * clean up shared state * fix shared state tests * wip * add alert test * wip * wip * wip * wip * Use transaction in binding * wip * wip * wip * wip * wip * wip * uikit * keep references to controllers when presenting so that we can properly dismiss * change order of features in shared state demo * wip * cleanup * cleanup * wip * wip * wip * Fix perception checking for effect actions. * wip * wip * wip * Fix perception checking for effect actions. * wip * wip * remove sync ups tutorial * wip * wip * wip * wip * wip * wip * wip * wip * wip * @Reducer macro will insert protocol requirements if missing * wip * fixes * fix * wip * wip * wip * docs for observe function for uikit * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Add cancellation to observation' * re-record integration test snapshots * fixed some todos * update test * remove 5.9.2 checks * wip * wip * improve docs * update docs * updates * lots of fixes * more docs * remove unneeded file; * wip * wip * wip * update readme and getting started * wip * wip * simplify * migration stuff * wip * Update Models.swift * wip * wip * wip * Update Bindings.md * wip * wip * wip * wip * fix * wip * wip * wip * wip * wip Co-authored-by: Kabir Oberai <oberai.kabir@gmail.com> * lots of docs and some fixes * more docs * more docs * wip * upate integration tests to use enum destination macro * re-org migration guide * wip * wip * docs for other enum reducer macros * update ephemeral state docs * wip * move docs for reducer protocol and macro into single article * mention observable state * wip * updated docs and some macro tests * wip * wip * cleanup * wip * wip * wip * revert 16 * wip * clean up * Revert "clean up" This reverts commit 49e7308. * Availability fixes * comment out tests crashing the compiler * wip * fix ttt tests * wip --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> Co-authored-by: George Scott <gscott@gekkoto.com> Co-authored-by: Kabir Oberai <oberai.kabir@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few small updates to @scogeo's work on caching in the perception checks (see #2630). I've mainly just removed the stats and moved things around. I considered removing the
maxCapacityentirely to keep things simple, but I do think it's necessary. The cache does get quite big over time.