`samples_mv` is unsafe

[jonashaag]

Description of the bug

We got crashes by using samples_mv when the original fitz handle was already deallocated.

IMO samples_mv should be changes so it should be renamed to something like unsafe_samples_mv.

How to reproduce the bug

Unfortunately I wasn't able to reproduce this outside of our production setting, but it went away by changing this code:

np.frombuffer(pixmap.samples_mv, ...)

to

np.frombuffer(pixmap.samples_mv, ...).copy()

PyMuPDF version

1.25.1

Operating system

Linux

Python version

3.12

[julian-smith-artifex-com]

Thanks for the report. We have a fix which will ensure that using the memoryview after the Pixmap has been destroyed will raise a ValueError.

Depending on internal review, this fix will hopefully make it into the next release.

[julian-smith-artifex-com]

Fixed in PyMuPDF-1.25.2.