Skip to content

Support a SOURCE_DATE_EPOCH prior to 1980 #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support a SOURCE_DATE_EPOCH prior to 1980 #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/src/hatchling/builders/wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ def __init__(self, project_id: str, *, reproducible: bool) -> None:
def get_reproducible_time_tuple() -> TIME_TUPLE:
from datetime import datetime, timezone

d = datetime.fromtimestamp(get_reproducible_timestamp(), timezone.utc)
# `zipfile.ZipInfo` does not support timestamps before 1980
min_ts = datetime(1980, 1, 1, tzinfo=timezone.utc).timestamp()
d = datetime.fromtimestamp(max(get_reproducible_timestamp(), min_ts), timezone.utc)
return d.year, d.month, d.day, d.hour, d.minute, d.second

def add_file(self, included_file: IncludedFile) -> tuple[str, str, str]:
Expand Down
13 changes: 10 additions & 3 deletions tests/backend/builders/test_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,14 @@ def test_default_auto_detection(self, hatch, helpers, temp_dir, config_file):
zip_info = zip_archive.getinfo(f'{metadata_directory}/WHEEL')
assert zip_info.date_time == (2020, 2, 2, 0, 0, 0)

def test_default_reproducible_timestamp(self, hatch, helpers, temp_dir, config_file):
@pytest.mark.parametrize(
('epoch', 'expected_date_time'),
[
('0', (1980, 1, 1, 0, 0, 0)),
('1580601700', (2020, 2, 2, 0, 1, 40)),
],
)
def test_default_reproducible_timestamp(self, hatch, helpers, temp_dir, config_file, epoch, expected_date_time):
config_file.model.template.plugins['default']['src-layout'] = False
config_file.save()

Expand All @@ -812,7 +819,7 @@ def test_default_reproducible_timestamp(self, hatch, helpers, temp_dir, config_f
build_path = project_path / 'dist'
build_path.mkdir()

with project_path.as_cwd(env_vars={'SOURCE_DATE_EPOCH': '1580601700'}):
with project_path.as_cwd(env_vars={'SOURCE_DATE_EPOCH': epoch}):
artifacts = list(builder.build(directory=str(build_path)))

assert len(artifacts) == 1
Expand All @@ -837,7 +844,7 @@ def test_default_reproducible_timestamp(self, hatch, helpers, temp_dir, config_f

with zipfile.ZipFile(str(expected_artifact), 'r') as zip_archive:
zip_info = zip_archive.getinfo(f'{metadata_directory}/WHEEL')
assert zip_info.date_time == (2020, 2, 2, 0, 1, 40)
assert zip_info.date_time == expected_date_time

def test_default_no_reproducible(self, hatch, helpers, temp_dir, config_file):
config_file.model.template.plugins['default']['src-layout'] = False
Expand Down