Prevent "unknown encoding: ASCII-8BIT" errors #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,6 +136,10 @@ def allowed_tags(options) | |||
| def allowed_attributes(options) | |||
| options[:attributes] || self.class.allowed_attributes | |||
| end | |||
|
|
|||
| def properly_encode(fragment, options) | |||
| fragment.xml? ? fragment.to_xml(options) : fragment.to_html(options) | |||
There was a problem hiding this comment.
I don't know how likely it is to sanitize an XML document, but I added it for completeness.
Nokogiri would throw these errors when outputting the fragment with #to_s. Instead call the format serializers directly and pass a UTF-8 encoding.
kaspth
force-pushed
the
accept-ascii-8bit-strings
branch
from
f3d1e7b to
2362298
Compare
|
👍 This change sanitizes without errors given strings from either the newer mysql2 or the older mysql gem (verified in the older version of my app that was having issues). |
|
@kindjar Great to hear 😉 |
kaspth
added a commit
that referenced
this pull request
Mar 6, 2015
Prevent "unknown encoding: ASCII-8BIT" errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
Nokogiri would throw these errors when outputting the fragment with #to_s.
Instead call the format serializers directly and pass a UTF-8 encoding.
cc @rafaelfranca @kindjar @ncri @Junichilto