fix(toolchain): fix compat with deploying using podman #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 8, 2025
NathanFlurry
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
35283d8 to
8634a7b
Compare
Deploying rivet with
|
| Latest commit: |
8c93674
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improves Docker archive handling compatibility for Podman and other container runtimes in the Rivet toolchain.
- Added
#[serde(default)]for DockerImageConfig's user field inpackages/toolchain/toolchain/src/util/docker/archive.rsto handle images without user specifications - Modified path prefix stripping logic to handle non-absolute paths from different container runtimes
- Maintains existing security restrictions around root user access while improving container runtime compatibility
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
NathanFlurry
force-pushed
the
06-05-feat_implement_clickhouse-user-query_
branch
from
1a2c0b8 to
ec1d934
Compare
NathanFlurry
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
8634a7b to
94015fb
Compare
Deploying rivet-hub with
|
| Latest commit: |
8c93674
|
| Status: | 🚫 Build failed. |
Deploying rivet-studio with
|
| Latest commit: |
8c93674
|
| Status: | 🚫 Build failed. |
MasterPtato
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
94015fb to
9b68bee
Compare
This was referenced Jun 9, 2025
Closed
MasterPtato
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
1caecf5 to
5fc553b
Compare
This was referenced Jun 16, 2025
MasterPtato
force-pushed
the
06-05-feat_implement_clickhouse-user-query_
branch
from
76d6218 to
eeb4a12
Compare
MasterPtato
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
5fc553b to
7c25a6d
Compare
This was referenced Jun 17, 2025
abcxff
force-pushed
the
06-05-feat_implement_clickhouse-user-query_
branch
from
eeb4a12 to
99715af
Compare
abcxff
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
7c25a6d to
1caecf5
Compare
MasterPtato
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
1caecf5 to
7c25a6d
Compare
MasterPtato
force-pushed
the
06-05-feat_implement_clickhouse-user-query_
branch
from
99715af to
eeb4a12
Compare
This was referenced Jun 19, 2025
NathanFlurry
force-pushed
the
06-05-feat_implement_clickhouse-user-query_
branch
from
eeb4a12 to
e0360dd
Compare
NathanFlurry
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
7c25a6d to
245dab7
Compare
This was referenced Jun 20, 2025
MasterPtato
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
245dab7 to
b7bcf50
Compare
MasterPtato
force-pushed
the
06-05-feat_implement_clickhouse-user-query_
branch
from
e0360dd to
ba59d98
Compare
MasterPtato
force-pushed
the
06-08-fix_toolchain_fix_compat_with_deploying_using_podman
branch
from
b7bcf50 to
8c93674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes