Skip to content

Resolve Visualize after 50/72 limit #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Jul 26, 2023
Merged

Resolve Visualize after 50/72 limit #32

merged 45 commits into from
Jul 26, 2023

Conversation

rockstaedt
Copy link
Owner

Closes #1

@rockstaedt rockstaedt added the patch Tags a patch release label Apr 2, 2023
@rockstaedt rockstaedt added this to the v1.0.0 milestone Apr 2, 2023
@rockstaedt rockstaedt self-assigned this Apr 2, 2023
@github-actions github-actions bot added feature New feature or request WIP Currently working on labels Apr 2, 2023
@codecov
Copy link

codecov bot commented Apr 2, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (49ce682) 100.00% compared to head (0b2e335) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines          160       203   +43     
=========================================
+ Hits           160       203   +43
Files Changed Coverage Δ
cmd/handler.go 100.00% <100.00%> (ø)
cmd/setup.go 100.00% <100.00%> (ø)
cmd/uninstall.go 100.00% <100.00%> (ø)
cmd/update.go 100.00% <100.00%> (ø)
cmd/validate.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rockstaedt rockstaedt marked this pull request as draft April 2, 2023 17:43
rockstaedt added 22 commits April 8, 2023 22:30
@rockstaedt
Reformat function
d1863cc
@rockstaedt
Move to 1 as error status
62cc1a8
@rockstaedt
Define tests for writing method
d2b7a9b
@rockstaedt
Transform fake writer to a mock
50d602d
@rockstaedt
Implement happy notify
051fcad
@rockstaedt
Enable custom message
f185bb4
@rockstaedt
Handle error at writing
00e4b64
@rockstaedt
Colorize text in green
b870db3
@rockstaedt
Colorize text in red
5619fb7
@rockstaedt
Adds linebreak after message
1a72f02
@rockstaedt
Avoid logging and colorize error messages
e883310
@rockstaedt
Use notify in setup command
366dd00
@rockstaedt
Set output stream of binary to Stdout
6344352
@rockstaedt
Simplify test
c211f0d
@rockstaedt
Use notify in uninstall command
4d4f03b
@rockstaedt
Use notify in update command
c686afb
@rockstaedt
Avoid usage of log
a6e18b0
@rockstaedt
Colorize text output in yellow
dcba66c
@rockstaedt
Use notify in validate command
107944b 
In this refactor, I also omitted the success message to align with
unix standards.
@rockstaedt
Increase coverage to 100%
30c1cad
@rockstaedt
Visualize characters after soft limit
bafec90
@rockstaedt
Harmonize structure of messsages
0b2e335
@rockstaedt rockstaedt marked this pull request as ready for review July 26, 2023 06:22
@rockstaedt rockstaedt merged commit 146f6f1 into main Jul 26, 2023
@rockstaedt rockstaedt deleted the 1-visualize-after-5072-limit branch July 26, 2023 06:22
@github-actions github-actions bot removed the WIP Currently working on label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rockstaedt rockstaedt

Labels
feature New feature or request patch Tags a patch release
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Visualize after 50/72 limit
1 participant
@rockstaedt