[cppyy] Only generate rootmaps for required classloader and stl tests #19105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronj0
added
in:Python Interface
in:Testing
clean build
Test Results 20 files 20 suites 3d 14h 25m 56s ⏱️ For more details on these failures, see this check. Results for commit c2128fc. ♻️ This comment has been updated with latest results. |
This variable is used in various stl type tests as `cppyy.gbl.N` but was always loaded through the datatypes dictionary. Since we disable rootmaps there, this variable should be added (regardless since that introduces a dependency on another tests dictionary
vepadulano
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement following #19100