[metacling] Destroy and release llvm::ManagedStatics #19109
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Jun 20, 2025
aaronj0
force-pushed
the
tcling-llvm-shutdown
branch
2 times, most recently
from
4b62f59 to
f5e3914
Compare
aaronj0
force-pushed
the
tcling-llvm-shutdown
branch
from
f5e3914 to
88740e4
Compare
Test Results 20 files 20 suites 3d 18h 52m 18s ⏱️ Results for commit 88740e4. |
|
Can you check if the clad timing system works through setting the env variable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18933
Following up on this issue, CppInterOp now uses ManagedStatic to support a stack of multiple interpreters. Although we do not use this feature (yet?), this shutdown call is now required in TCling.