-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] use cmake for io/references #19156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Split ref file - while several macros run
Modify a bit refarray.ref to simplify sed expression Compile A.C and lotsRef.C macros directly - without create.C Put generation of dictionary into broken_tests branch, it fails anyway
Test Results 20 files 20 suites 3d 5h 54m 15s ⏱️ Results for commit 7f2a550. ♻️ This comment has been updated with latest results. |
Add `#pragma link C++ class A+;` to A.C to satisfy windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The windows failures in roottest-root-io-bigevent-IoBigEventGenerator-build seems to indicate a potential 'race condition' but it is not clear whether it is related to this PR or not. |
Allows to link both of them and remove extra linkdef entry in A.C
b9cca61
to
7f2a550
Compare
Do not use label
longtest
while each single test is relatively fastSplit refs file which were produced by concatenation of output of several tests
Put under
if(broken_tests)
generation of dictionary which fails, was also so in MakefileDirectly compile macro without using
create.C
which just deleted