Skip to content

[roottest] use cmake for io/references #19156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2025

Conversation

linev
Copy link
Member

@linev linev commented Jun 24, 2025

Do not use label longtest while each single test is relatively fast
Split refs file which were produced by concatenation of output of several tests
Put under if(broken_tests) generation of dictionary which fails, was also so in Makefile
Directly compile macro without using create.C which just deleted

linev added 2 commits June 24, 2025 17:21
Split ref file - while several macros run
Modify a bit refarray.ref to simplify sed expression
Compile A.C and lotsRef.C macros directly - without create.C
Put generation of dictionary into broken_tests branch, it fails anyway
Copy link

github-actions bot commented Jun 24, 2025

Test Results

    20 files      20 suites   3d 5h 54m 15s ⏱️
 3 066 tests  3 066 ✅ 0 💤 0 ❌
59 717 runs  59 717 ✅ 0 💤 0 ❌

Results for commit 7f2a550.

♻️ This comment has been updated with latest results.

@linev linev requested a review from pcanal June 26, 2025 11:59
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pcanal
Copy link
Member

pcanal commented Jun 26, 2025

The windows failures in roottest-root-io-bigevent-IoBigEventGenerator-build seems to indicate a potential 'race condition' but it is not clear whether it is related to this PR or not.

Allows to link both of them and remove extra linkdef entry in A.C
@linev linev force-pushed the roottest_io_references branch from b9cca61 to 7f2a550 Compare June 26, 2025 18:48
@linev linev merged commit bdc71c2 into root-project:master Jun 27, 2025
24 of 25 checks passed
@linev linev deleted the roottest_io_references branch June 27, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants