[DO NOT MERGE] I wonder if this helps the derive...

[scottmcm]

r? ghost

[scottmcm]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 08305b2 with merge 6b75ff0...

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

info: removing rustup binaries
info: rustup is uninstalled
##[group]Image checksum input
mingw-check-tidy
# We use the ghcr base image because ghcr doesn't have a rate limit
# and the mingw-check-tidy job doesn't cache docker images in CI.
FROM ghcr.io/rust-lang/ubuntu:22.04
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
  g++ \
  make \
---

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#12 2.771 Building wheels for collected packages: reuse
#12 2.773   Building wheel for reuse (pyproject.toml): started
#12 2.986   Building wheel for reuse (pyproject.toml): finished with status 'done'
#12 2.987   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=0c2fd2aaf7b0bf8d6e131220aff14712a774c2ca462f3204d25460cbcf610b63
#12 2.987   Stored in directory: /tmp/pip-ephem-wheel-cache-rphe1pbi/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#12 2.990 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#12 3.396 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#12 3.396 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 3.927 Collecting virtualenv
#12 3.927 Collecting virtualenv
#12 3.965   Downloading virtualenv-20.29.2-py3-none-any.whl (4.3 MB)
#12 4.073      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 40.8 MB/s eta 0:00:00
#12 4.128 Collecting platformdirs<5,>=3.9.1
#12 4.132   Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#12 4.169 Collecting filelock<4,>=3.12.2
#12 4.191 Collecting distlib<1,>=0.3.7
#12 4.195   Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#12 4.203      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 80.1 MB/s eta 0:00:00
#12 4.203      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 80.1 MB/s eta 0:00:00
#12 4.283 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#12 4.468 Successfully installed distlib-0.3.9 filelock-3.17.0 platformdirs-4.3.6 virtualenv-20.29.2
#12 DONE 4.5s

#13 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#13 DONE 0.0s
---
DirectMap4k:      147392 kB
DirectMap2M:     8241152 kB
DirectMap1G:    10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
downloading https://static.rust-lang.org/dist/2025-02-18/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
---
fmt check
error: invalid comparison operator `<=>`
##[error]  --> /checkout/tests/mir-opt/building/spaceship.rs:11:7
   |
11 |     a <=> b
   |       ^^^ `<=>` is not a valid comparison operator, use `std::cmp::Ordering`
error: invalid comparison operator `<=>`
##[error]  --> /checkout/tests/mir-opt/building/spaceship.rs:18:7
   |
18 |     a <=> b
18 |     a <=> b
   |       ^^^ `<=>` is not a valid comparison operator, use `std::cmp::Ordering`
Diff in /checkout/compiler/rustc_parse/src/parser/expr.rs:156:
         self.expected_token_types.insert(TokenType::Operator);
         while let Some(mut op) = self.check_assoc_op() {
             // Look for `<=>`
             // Look for `<=>`
-            if op.node == AssocOp::Binary(BinOpKind::Le) && self.look_ahead(1, |t| *t == token::Gt) {
+            if op.node == AssocOp::Binary(BinOpKind::Le) && self.look_ahead(1, |t| *t == token::Gt)
+            {
                 //let sp = op.span.to(self.token.span);
                 //op = source_map::respan(sp, AssocOp::Cmp);
                 op.node = AssocOp::Binary(BinOpKind::Cmp);
Build completed unsuccessfully in 0:01:12
  local time: Sat Mar  1 10:26:08 UTC 2025
  network time: Sat, 01 Mar 2025 10:26:08 GMT
##[error]Process completed with exit code 1.

[bors]

☀️ Try build successful - checks-actions
Build commit: 6b75ff0 (6b75ff0f9e2c4e74dc186322655f6c0234fbd5e4)

[rust-timer]

Finished benchmarking commit (6b75ff0): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-3.1%, -0.3%]	10
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.4%	[-3.4%, -3.4%]	1

Cycles

Results (secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-3.0%, -2.2%]	6
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	10
Improvements ✅ (secondary)	-0.2%	[-0.5%, -0.0%]	11
All ❌✅ (primary)	0.0%	[-0.0%, 0.2%]	16

Bootstrap: 772.769s -> 773.332s (0.07%)
Artifact size: 361.98 MiB -> 362.00 MiB (0.00%)