GCC backend subtree update #143161

GuillaumeGomez · 2025-06-28T21:38:03Z

r? ghost

- Rename `USED` to `USED_COMPILER` to better reflect its behavior. - Reorder some items to group the used and allocator flags together - Renumber them without gaps

…a itself

There is no safety contract and I don't think any of them can actually cause UB in more ways than passing malicious source code to rustc can. While LtoModuleCodegen::optimize says that the returned ModuleCodegen points into the LTO module, the LTO module has already been dropped by the time this function returns, so if the returned ModuleCodegen indeed points into the LTO module, we would have seen crashes on every LTO compilation, which we don't. As such the comment is outdated.

atomic_load intrinsic: use const generic parameter for ordering We have a gazillion intrinsics for the atomics because we encode the ordering into the intrinsic name rather than making it a parameter. This is particularly bad for those operations that take two orderings. Let's fix that! This PR only converts `load`, to see if there's any feedback that would fundamentally change the strategy we pursue for the const generic intrinsics. The first two commits are preparation and could be a separate PR if you prefer. `@BoxyUwU` -- I hope this is a use of const generics that is unlikely to explode? All we need is a const generic of enum type. We could funnel it through an integer if we had to but an enum is obviously nicer... `@bjorn3` it seems like the cranelift backend entirely ignores the ordering?

This avoids having to get the function signature.

Added support for testing the backend with abi-cafe

Fixed some clippy warnings.

Skip needless calls to get_align in some cases.

…ble.

Refactored the codebase to use Function instead of RValue where possible.

… a call to function.

Remove unnecesary uses of the 'current_func' field, replacing it with a call to function.

…6_02 Sync from rust 2025/06/02

…update_cg_gcc_2025-06-28

rustbot · 2025-06-28T21:38:07Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

compiler/rustc_codegen_gcc/src/builder.rs

antoyo · 2025-06-28T22:19:09Z

Are we doing something seriously wrong with our subtree syncs? This commit was already done in the subtree here.
I even frequently get conflicts between my own changes.
Any ideas what could cause all this?

GuillaumeGomez · 2025-06-28T22:21:03Z

I think it's coming from a weird mix of git changes and my lack of knowledge on this part of cg_gcc.

GuillaumeGomez · 2025-06-28T22:36:18Z

@bors delegate=antoyo

bors · 2025-06-28T22:36:20Z

✌️ @antoyo, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, please make that change, then do @bors r=@GuillaumeGomez

antoyo · 2025-06-28T23:41:38Z

@bors r=GuillaumeGomez p=1

bors · 2025-06-28T23:41:41Z

📌 Commit 3dcbc1e has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-06-29T04:18:50Z

⌛ Testing commit 3dcbc1e with merge dddd7ab...

bors · 2025-06-29T07:21:32Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing dddd7ab to master...

github-actions · 2025-06-29T07:24:38Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8141c22 (parent) -> dddd7ab (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard dddd7ab96229ea5f2ca96afcb5984a9831393a13 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 7925.9s -> 6112.5s (-22.9%)
x86_64-apple-2: 5668.2s -> 4627.2s (-18.4%)
mingw-check-1: 1842.0s -> 1539.1s (-16.4%)
mingw-check-2: 2120.0s -> 1827.2s (-13.8%)
x86_64-rust-for-linux: 2946.9s -> 2545.2s (-13.6%)
i686-gnu-2: 6174.1s -> 5412.1s (-12.3%)
i686-gnu-nopt-1: 7980.9s -> 7012.4s (-12.1%)
i686-gnu-1: 8210.4s -> 7330.8s (-10.7%)
x86_64-gnu-tools: 3636.2s -> 3248.4s (-10.7%)
x86_64-gnu-llvm-20-1: 3569.2s -> 3224.8s (-9.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-29T08:48:19Z

Finished benchmarking commit (dddd7ab): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.3%, secondary 7.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.1%	[7.1%, 7.1%]	1
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.3%	[-1.3%, -1.3%]	1

Cycles

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[1.9%, 3.4%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 693.957s -> 696.482s (0.36%)
Artifact size: 371.70 MiB -> 371.74 MiB (0.01%)

Noratrieb and others added 30 commits May 24, 2025 20:31

Cleanup CodegenFnAttrFlags

8ad6957

- Rename `USED` to `USED_COMPILER` to better reflect its behavior. - Reorder some items to group the used and allocator flags together - Renumber them without gaps

Pass PlaceRef rather than Bx::Value to codegen_intrinsic_call

0348509

Remove usage of FnAbi in codegen_intrinsic_call

f994713

Remove codegen_unit from MiscCodegenMethods

f6489c3

Remove a couple of uses of interior mutability around statics

4d47f6d

Make predefine methods take &mut self

f297400

Remove methods from StaticCodegenMethods that are not called in cg_ss…

96be6ef

…a itself

Remove unused arg_memory_ty method

0c6f946

get rid of rustc_codegen_ssa::common::AtomicOrdering

dbbfb6e

Use layout field of OperandRef and PlaceRef in codegen_intrinsic_call

5c4b797

This avoids having to get the function signature.

Use layout field of OperandRef in generic_simd_intrinsic

926c8c8

Avoid computing function type for intrinsic instances

6c6c31d

Directly use from_immediate for handling bool

f383b17

Merge branch 'master' into sync_from_rust_2025_06_02

f69d8fc

Update to nightly-2025-06-02

2d7d0ee

Remove unneeded patch

38f134c

Make comment more specific

2e89179

Added support for testing the backend with abi-cafe

ed441b6

Merge pull request rust-lang#710 from FractalFir/abi-cafe

395bca1

Added support for testing the backend with abi-cafe

Fixed some clippy warnings.

b2b117e

Merge pull request rust-lang#716 from FractalFir/abi-cafe

962a08f

Fixed some clippy warnings.

Skip needless calls to get_align in some cases.

8571aee

Merge pull request rust-lang#718 from FractalFir/needless_align

54b1ff5

Skip needless calls to get_align in some cases.

Refactored the codebase to use Function instead of RValue where possi…

b03f7f8

…ble.

Merge pull request rust-lang#720 from FractalFir/func_refactor

79564c8

Refactored the codebase to use Function instead of RValue where possible.

Remove unnecesary uses of the 'current_func' field, replacing it with…

413821f

… a call to function.

Merge pull request rust-lang#722 from FractalFir/func_refactor

98d65f2

Remove unnecesary uses of the 'current_func' field, replacing it with a call to function.

Fix type_name intrinsic

7c71c83

antoyo and others added 4 commits June 28, 2025 15:40

Add TODOs

f876b18

Stop skipping libcore's f16::test_total_cmp

8385f3c

Merge pull request rust-lang#694 from rust-lang/sync_from_rust_2025_0…

b7091ec

…6_02 Sync from rust 2025/06/02

Merge commit 'b7091eca6d8eb0fe88b58cc9a7aec405d8de5b85' into subtree-…

f8491b1

…update_cg_gcc_2025-06-28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 28, 2025

This comment has been minimized.

Sign in to view

Remove unwanted semi-colon in rustc_codegen_gcc

13d0ef3

This comment has been minimized.

Sign in to view

Fix signature of filter_landing_pad

a420d39

antoyo reviewed Jun 28, 2025

View reviewed changes

compiler/rustc_codegen_gcc/src/builder.rs Outdated Show resolved Hide resolved

Remove () returned value

3dcbc1e

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2025

bors merged commit dddd7ab into rust-lang:master Jun 29, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jun 29, 2025

bors mentioned this pull request Jun 29, 2025

Move scalar_to_backend to ssa #142960

Open

GuillaumeGomez deleted the subtree-update_cg_gcc_2025-06-28 branch June 29, 2025 09:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GCC backend subtree update #143161

GCC backend subtree update #143161

GuillaumeGomez commented Jun 28, 2025

Uh oh!

rustbot commented Jun 28, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

antoyo commented Jun 28, 2025

Uh oh!

GuillaumeGomez commented Jun 28, 2025

Uh oh!

GuillaumeGomez commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

antoyo commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 29, 2025

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

Uh oh!

GCC backend subtree update #143161

GCC backend subtree update #143161

Conversation

GuillaumeGomez commented Jun 28, 2025

Uh oh!

rustbot commented Jun 28, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

antoyo commented Jun 28, 2025

Uh oh!

GuillaumeGomez commented Jun 28, 2025

Uh oh!

GuillaumeGomez commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

antoyo commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 29, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 29, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!