Skip to content

Fix classifcation report imbalance; y_true before y_pred when calling… #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

klizter
Copy link
Contributor

@klizter klizter commented Jan 23, 2018

… geo_mean and iba_geo_mean

Reference Issue

closes #394

What does this implement/fix? Explain your changes.

Fixes geometic_mean_accuracy and index_balanced_mean_accuracy; y_true parameter before y_pred

Any other comments?

@glemaitre
Copy link
Member

You probably need to update the tests values.

@klizter
Copy link
Contributor Author

klizter commented Jan 24, 2018

Ok. Comming up!

@codecov
Copy link

codecov bot commented Feb 22, 2018

Codecov Report

Merging #397 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   98.77%   98.78%   +0.01%     
==========================================
  Files          67       68       +1     
  Lines        3927     3961      +34     
==========================================
+ Hits         3879     3913      +34     
  Misses         48       48
Impacted Files Coverage Δ
imblearn/metrics/classification.py 96.77% <ø> (ø) ⬆️
imblearn/utils/estimator_checks.py 95.83% <0%> (-0.03%) ⬇️
imblearn/over_sampling/adasyn.py 98.5% <0%> (ø) ⬆️
imblearn/ensemble/classifier.py 100% <0%> (ø) ⬆️
imblearn/tests/test_base.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab9fcf...39e35ca. Read the comment docs.

@glemaitre glemaitre merged commit 0dbacc7 into scikit-learn-contrib:master Feb 22, 2018
@glemaitre
Copy link
Member

Thanks

glemaitre pushed a commit that referenced this pull request Feb 22, 2018
@glemaitre
Copy link
Member

I fix the tests and merged. Thanks for the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geometric_mean_score inside classification_report_imbalanced is wrong?
2 participants