Skip to content

Fixed issue #187 "Support datetimeoffset as a column type for default column Timestamp" #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ckadluba
Copy link
Member

@ckadluba ckadluba commented Jan 14, 2020

What issue does this PR address?

Fixed issue #187 "Support datetimeoffset as a column type for default column Timestamp" and added tests.

Does this PR introduce a breaking change?

No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:

@ckadluba ckadluba changed the title Fixed issue #187 Fixed issue #187 "Support datetimeoffset as a column type" Jan 14, 2020
@ckadluba ckadluba changed the title Fixed issue #187 "Support datetimeoffset as a column type" Fixed issue #187 "Support datetimeoffset as a column type for default column Timestamp" Jan 14, 2020
@ckadluba ckadluba requested review from MV10 and nblumhardt and removed request for MV10 January 14, 2020 23:00
@nblumhardt
Copy link
Contributor

Nice PR - thanks!

@nblumhardt nblumhardt merged commit afb6545 into serilog-mssql:dev Jan 20, 2020
@ckadluba
Copy link
Member Author

Thank you very much! 😊

@ckadluba ckadluba deleted the issue-187-datetimeoffset-timestamp branch March 10, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants