improvement(connection) #527
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced connection blocks and workflow visualization with improved block relationship handling and UI refinements.
- Improved
TagDropdowninapps/sim/components/ui/tag-dropdown.tsxwith block-based grouping and distance-based sorting using BFS - Added horizontal/vertical handle orientation support in
apps/sim/app/w/[id]/components/workflow-block/components/connection-blocks/connection-blocks.tsx - Modified
findAllPathNodesinuse-block-connections.tsto include distance information for connected blocks with proper sorting - Enhanced text overflow handling in
workflow-block.tsxwith dynamic max width based on block state
4 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile
| maxWidth: !isEnabled | ||
| ? isWide | ||
| ? '200px' | ||
| : '140px' | ||
| : isWide | ||
| ? '220px' | ||
| : '180px', |
There was a problem hiding this comment.
style: Consider extracting these width values into a config object for better maintainability
| function findAllPathNodes( | ||
| edges: any[], | ||
| targetNodeId: string | ||
| ): Array<{ nodeId: string; distance: number }> { |
There was a problem hiding this comment.
style: Consider adding type definitions for edges array parameter instead of using any[]. This would improve type safety.
| const displayName = connection.name.replace(/\s+/g, '').toLowerCase() | ||
| // Get block configuration for icon and color | ||
| const blockConfig = getBlock(connection.type) | ||
| const displayName = connection.name // Use the actual block name instead of transforming it |
There was a problem hiding this comment.
style: Comment previously mentioned transforming name but code shows raw usage. Remove outdated comment
| const displayName = connection.name // Use the actual block name instead of transforming it | |
| const displayName = connection.name |
|
|
||
| return ( | ||
| <Card | ||
| key={`${field ? field.name : connection.id}`} | ||
| key={`${connection.id}-${field ? field.name : 'default'}`} |
There was a problem hiding this comment.
logic: Key should include index to handle duplicate field names across different blocks
emir-karabeg
force-pushed
the
improvement/connection
branch
from
010c826 to
3810313
Compare
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
bun run test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.