Skip to content
This repository was archived by the owner on Mar 27, 2023. It is now read-only.

Restore original reporter after compilation #33

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Restore original reporter after compilation #33

merged 2 commits into from
Jan 13, 2017

Conversation

kciesielski
Copy link
Member

  • In multi-module sbt projects the build system needs its original reporter back between subsequent module compilations.

@kciesielski
Restore original reporter after compilation
e69b6f5 
- In multi-module sbt projects the build system needs its original reporter back between subsequent module compilations.
@kciesielski kciesielski mentioned this pull request Jan 13, 2017
Closed
adamw
adamw reviewed Jan 13, 2017
View reviewed changes
plugin/src/main/scala/com/softwaremill/clippy/RestoreReporter.scala
import scala.tools.nsc.plugins.PluginComponent
import scala.tools.nsc.{Global, Phase}

class RestoreReporter(val global: Global) extends PluginComponent {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a short doc on why this is necessary? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, added some doc :)

@adamw adamw merged commit f322a4c into softwaremill:master Jan 13, 2017
@adamw
Copy link
Member

adamw commented Jan 13, 2017

0.4.0 released, hopefully things will work this time :)

@ksilin
Copy link

ksilin commented Feb 7, 2017 •
edited
Loading

Issue reoccurring with 0.5.0. Project with four modules, scala-clippy as global sbt plugin. Unfortunately cannot share code but will attempt to reproduce.

@adamw
Copy link
Member

adamw commented Feb 7, 2017

@ksilin what's the error you are getting? which version of sbt?

@ksilin
Copy link

ksilin commented Feb 7, 2017

Have been getting a java.lang.ClassCastException: com.softwaremill.clippy.DelegatingReporter cannot be cast to xsbt.DelegatingReporter for quite some time yesterday . However I must have done sth recently and can no longer reproduce it 😕 scala-clippy 0.5.0, sbt 1-SNAPSHOT. Sry for the trouble.

@adamw
Copy link
Member

adamw commented Feb 7, 2017

hmm, 1-snapshot, living on the edge :) well if you would have a way to reproduce this we'll certainly take a look :)

@kciesielski kciesielski deleted the restore-reporter branch February 7, 2017 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamw adamw adamw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kciesielski @adamw @ksilin