This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix Cody Web CSS #64370
Merged
Fix Cody Web CSS #64370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenamankumar
added
the
backport 5.6.x
rrhyne
approved these changes
Aug 8, 2024
thenamankumar
commented
Aug 8, 2024
| @@ -157,10 +167,71 @@ | |||
| :global([cmdk-root] input:focus-visible) { | |||
| box-shadow: unset !important; | |||
| } | |||
|
|
|||
| // As of Cody Web 0.4.0 the buttons implemented in Cody does not satisfy | |||
There was a problem hiding this comment.
As the buttons implemented in Cody does not satisfy the design requirements and it will take longer to design them correctly, then making code changes in Cody, release Cody Web, and then finally update SG. I have been told to override the styles for buttons in SG for the patch release. And the team (me or someone else) will be follow up fixing Cody in next couple of days.
|
Pulled it down and took a peek. The only thing obvious I noticed was that the
|
camdencheek
approved these changes
Aug 8, 2024
updated. |
camdencheek
force-pushed
the
naman/cody-web-css-fixes
branch
from
c4e82e1 to
ff6a2db
Compare
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
closes: https://linear.app/sourcegraph/issue/SRCH-866/improve-cody-web-theming-for-consistency-with-rest-of-product This PR updates the Cody Web CSS based on the changes requested by @rrhyne. Few buttons implemented in Cody doesn't satisfy the design requirements and do not use the css variable so we couldn't update them easily but rather had to override the styles. ## Test plan Before:  After:  ## Changelog - Make Cody Web styles more accessible. (cherry picked from commit 2dd38b3)
camdencheek
pushed a commit
that referenced
this pull request
Aug 8, 2024
closes: https://linear.app/sourcegraph/issue/SRCH-866/improve-cody-web-theming-for-consistency-with-rest-of-product This PR updates the Cody Web CSS based on the changes requested by @rrhyne. Few buttons implemented in Cody doesn't satisfy the design requirements and do not use the css variable so we couldn't update them easily but rather had to override the styles. ## Test plan Before:  After:  ## Changelog - Make Cody Web styles more accessible. <br> Backport 2dd38b3 from #64370 Co-authored-by: Naman Kumar <naman@outlook.in>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://linear.app/sourcegraph/issue/SRCH-866/improve-cody-web-theming-for-consistency-with-rest-of-product
This PR updates the Cody Web CSS based on the changes requested by @rrhyne.
Few buttons implemented in Cody doesn't satisfy the design requirements and do not use the css variable so we couldn't update them easily but rather had to override the styles.
Test plan
Before:
After:
Changelog