Skip to content

Fabric8 it part 15 #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Fabric8 it part 15 #1486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
913143c
started work
wind57 Oct 22, 2023
4d1ad87
refactored one IT
wind57 Oct 22, 2023
957bc7d
refactored one IT
wind57 Oct 23, 2023
a786c6f
remove
wind57 Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion spring-cloud-kubernetes-integration-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,12 @@
<!-- since discovery controller is based on k8s-client, we do not have a fabric8 module -->
<module>spring-cloud-kubernetes-k8s-client-discovery-server</module>

<!-- configuration watcher is based on k8s-client, there's no fabric8 counterpart -->
<module>spring-cloud-kubernetes-k8s-client-configuration-watcher</module>

<module>spring-cloud-kubernetes-fabric8-istio-it</module>

<module>spring-cloud-kubernetes-client-loadbalancer-it</module>
<module>spring-cloud-kubernetes-configuration-watcher-it</module>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is more then one thing going on in this PR, I'll try to explain everything. The first change is to rename the module, so it becomes on par with the previous changes we made. This is the simplest change here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other change (there is a longer comment in ActuatorRefreshKafkaIT), is that we can drop two integration tests, they are not needed anymore, their logical testing is done elsewhere already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also refactored two existing tests so that they are faster

<module>spring-cloud-kubernetes-client-configmap-event-reload-multiple-apps</module>
<module>spring-cloud-kubernetes-client-secrets-event-reload-multiple-apps</module>
</modules>
Expand Down
53 changes: 0 additions & 53 deletions .../springframework/cloud/kubernetes/configuration/watcher/ConfigWatcherTestApplication.java
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions ...ests/spring-cloud-kubernetes-configuration-watcher-it/src/main/resources/application.yaml
View file
Open in desktop

This file was deleted.

162 changes: 0 additions & 162 deletions ...va/org/springframework/cloud/kubernetes/configuration/watcher/ActuatorRefreshKafkaIT.java
View file
Open in desktop

This file was deleted.

Loading