Make 'TomcatEmbeddedServletContainerFactory.DEFAULT_PROTOCOL' public

[apogrebnyak]

I need to add another connector to Tomcat (unsecure HTTP connector for default access redirect), and would like it to be consistent with the default connector created by the factory.

Unfortunately factory's protocol member variable is declared private and there is no getter for it.

[philwebb]

We don't have many getters on that class. Would making DEFAULT_PROTOCOL public do the trick?

[apogrebnyak]

Yes, as I can then use TomcatEmbeddedServletContainerFactory.setProtocol and tie 2 connectors together.

However, out of curiosity, why there are no getters?

[philwebb]

Mainly because that class is intended to build the TomcatEmbeddedServletContainer. I assumed that the person using the class wouldn't need to access the things they just set.

[apogrebnyak]

Because the container factory is customizable through several EmbeddedServletContainerCustomizers and each one of them can change the state of the factory, I think it is useful to have getters on the factory in general.

It just turns out that none of the framework EmbeddedServletContainerCustomizers sets the protocol, so this setProtocol approach works for me, but it is not a real substitute for a getter.