GH-2357: Switch to CompletableFuture #2360
Conversation
Resolves spring-projects#2357 Spring Framework is planning to deprecate `ListenableFuture` in 6.0. Add methods to the `KafkaOperations` (`KafkaTemplate`) that return `CompletableFuture` instead; the `ListenableFuture` methods have now been removed in 3.0.
| * @deprecated no longer needed; use {@code KafkaOperations}. | ||
| */ | ||
| @Deprecated | ||
| public interface KafkaOperations2<K, V> { |
There was a problem hiding this comment.
Why cannot we remove it altogether?
I believe there is going to a migration from 2.8.x to 3.0.0 mostly through Spring Boot, so that replacement in the API of the KafkaOperations is going to be a breaking change anyway.
Therefore this one is just an extra burden for us to bear for the next version.
What do I miss?
Thanks
There was a problem hiding this comment.
I was thinking of people that had taken advantage of the migration path provided by 2.9.x...
KafkaOperations2<Integer, String> templateTx = new KafkaTemplate<>(pfTx).usingCompletableFuture();
This code would still work with 3.0 (with a deprecation warning only).
But, I suppose with a major release, this breaking change might be acceptable.
WDYT?
There was a problem hiding this comment.
Yes, that's my idea as well: bite the bullet and remove.
One more breaking change won't hurt as it is already with those replaced return types.
Resolves #2357
Spring Framework is planning to deprecate
ListenableFuturein 6.0.Add methods to the
KafkaOperations(KafkaTemplate) that returnCompletableFutureinstead; theListenableFuturemethods have nowbeen removed in 3.0.