This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Set codegate version from build argument in container #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codegate container does not run the python program via poetry, thus it does not have the necessary package metadata to determine the version. To work around this lack of information, this enhancement leverages Docker build arguments to set a special variable that will set the version. This way, we don't need to rely on package metadata nor manually bump the version. This machinery was set up in both the local image building and in CI, so we'll get the version and a commit hash. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
blkt
approved these changes
Jan 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegate container does not run the python program via poetry, thus
it does not have the necessary package metadata to determine the
version.
To work around this lack of information, this enhancement leverages
Docker build arguments to set a special variable that will set the
version. This way, we don't need to rely on package metadata nor
manually bump the version. This machinery was set up in both the local
image building and in CI, so we'll get the version and a commit hash.
Sample output looks as follows: