-
-
Notifications
You must be signed in to change notification settings - Fork 841
feat: add stats/base/dists/kumaraswamy/stdev
#4513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats/base/dists/kumaraswamy/stdev
#4513
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
/stdlib update-copyright-years |
/stdlib lint-autofix |
@stdlib/stats/base/dists/kumaraswamy/stdev
stats/base/dists/kumaraswamy/stdev
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/manifest.json
Outdated
Show resolved
Hide resolved
...tdlib/stats/base/dists/kumaraswamy/stdev/include/stdlib/stats/base/dists/kumaraswamy/stdev.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/package.json
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/test/test.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/src/main.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ShabiShett07! Did a first review pass and left some comments.
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
/stdlib update-copyright-years |
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@Planeshifter, I have added test fixtures, but the problem we have here is high tolerance, which went up to 10000 times epsilon. Is this acceptable? |
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
/stdlib merge |
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/stdev/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
Added a comment due to the massive tolerance needed here; but I cannot find anything wrong.
Got it, thanks a lot for reviewing this because the tolerance thing was too concerning for me |
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #3706
Description
This pull request:
@stdlib/stats/base/dists/kumaraswamy/stdev
#3706Related Issues
This pull request:
@stdlib/stats/base/dists/kumaraswamy/stdev
#3706Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers