Skip to content

chore: fix C lint errors (issue #5432) #7469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GeoDaoyu
Copy link
Contributor

Resolves #5432.

Description

What is the purpose of this pull request?

This pull request:

  • fix C lint errors with // cppcheck-suppress constVariablePointer

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 24, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/assign $\color{red}4689/10531$
$\color{green}+44.53\%$
$\color{green}44/44$
$\color{green}+100.00\%$
$\color{red}0/45$
$\color{green}+0.00\%$
$\color{red}4689/10531$
$\color{green}+44.53\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Jun 24, 2025

As stated at L20 of the source file, the source is auto-generated and should not be modified. What needs modifying are the macros. As such, I will go ahead and close this PR.

@kgryte kgryte closed this Jun 24, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 24, 2025
@GeoDaoyu
Copy link
Contributor Author

I saw the L20, so
should I add // cppcheck-suppress constVariablePointer auto-generated in lib/node_modules/@stdlib/ndarray/base/assign/scripts/loops.js

@GeoDaoyu GeoDaoyu deleted the fix/CLint5432 branch June 24, 2025 13:51
@kgryte
Copy link
Member

kgryte commented Jun 26, 2025

No, we need to actually update the macros to address the root cause.

@GeoDaoyu
Copy link
Contributor Author

No, we need to actually update the macros to address the root cause.

Fine.I probably don't have the ability to solve those problems.🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants