Fix min loglevel #951
Open
Fix min loglevel #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs to indicate that log level passed to plugins is the min log level Don't allow changing the log level of the default logger after initialization Set Kermit minSeverity using logLevel
Sure, so it was built so you could set the log level per module, also explaining this:
It was internal because because you'd set it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, feature, docs update
What is the current behavior?
The global Kermit minSeverity will take precedence if it is higher than specified logLevel.
What is the new behavior?
There doesn't appear to be good way to respect DEFAULT_LOG_LEVEL and the global minSeverity, so we should specify override the minSeverity.
Additional context
The phrase "default logging level" could mean default level at and above which logs are shown, or default level applied to logs. I updated the docs specify this.
Finally, KermitSupabaseLogger seemed to be accidentally exposed in the API. I changed the API values to be explicit SupabaseLogger and made KermitSupabaseLogger internal. Also, setLevel was internal and never called, so I removed it.