Skip to content

fix: don't mark deriveds as clean if updating during teardown #15997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025

Conversation

Rich-Harris
Copy link
Member

Fixes the issue reported here: https://www.reddit.com/r/sveltejs/comments/1ku7skr/can_someone_explain_this_weird_behavior_i_really. Previously, deriveds read during effect teardown were being marked clean, which caused them to hold onto incorrect values if they depended on state that had just changed

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15997

@Rich-Harris Rich-Harris merged commit a38ea02 into main May 25, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the dont-cache-stale-derived branch May 25, 2025 12:29
@github-actions github-actions bot mentioned this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants