Basics: introduce some native path representation helpers #6454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
MaxDesiatov
reviewed
Apr 19, 2023
MaxDesiatov
approved these changes
Apr 19, 2023
|
@swift-ci please smoke test |
tomerd
reviewed
Apr 19, 2023
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test |
tomerd
reviewed
May 1, 2023
tomerd
reviewed
May 1, 2023
tomerd
reviewed
May 1, 2023
compnerd
force-pushed
the
aboriginal
branch
2 times, most recently
from
de6a4a4 to
bbf6b76
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
Okay, tested locally on Windows and macOS, I think that this should be good on both finally! |
tomerd
reviewed
May 1, 2023
|
@swift-ci please smoke test |
|
@swift-ci please test |
We end up needing these in a few places, and while we could make it `internal` and use `@testable` imports in the tests, this ends up being needed in `Build` and `PackageLoading`. Ideally, we would give it package visibility, but that functionality would not be backwards compatible. This is a reluctant approach at solving that problem by using `public` visibility.
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please test |
tomerd
approved these changes
May 1, 2023
MaxDesiatov
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We end up needing these in a few places, and while we could make it
internaland use@testableimports in the tests, this ends up being needed inBuildandPackageLoading. Ideally, we would give it package visibility, but that functionality would not be backwards compatible. This is a reluctant approach at solving that problem by usingpublicvisibility.