Minor code cleanup in PackageSigning #6462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yim-lee
commented
Apr 21, 2023
yim-lee
commented
- Remove macOS 11 check since macOS 12 is required now
- Add test
- Remove macOS 11 check since macOS 12 is required now - Add test
yim-lee
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
neonichu
approved these changes
Apr 21, 2023
MaxDesiatov
approved these changes
Apr 21, 2023
MaxDesiatov
reviewed
Apr 21, 2023
|
|
||
| func ecADPKeyAndCertChain(callback: (Result<KeyAndCertChain, Error>) -> Void) { | ||
| do { | ||
| try fixture(name: "Signing", createGitRepo: false) { fixturePath in |
There was a problem hiding this comment.
Is the fact that fixture is callback-based the only reason to make ecADPKeyAndCertChain callback-based?
There was a problem hiding this comment.
Yes. Is there an async version of fixture?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.