Skip to content

Tests: prefer to use first rather than indexing #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2023
Merged

Tests: prefer to use first rather than indexing #6502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Tests/SPMBuildCoreTests/PluginInvocationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ class PluginInvocationTests: XCTestCase {
XCTAssert(packageGraph.packages.count == 1, "\(packageGraph.packages)")

// Find the build tool plugin.
let buildToolPlugin = try XCTUnwrap(packageGraph.packages[0].targets.map(\.underlyingTarget).first{ $0.name == "MyPlugin" } as? PluginTarget)
let buildToolPlugin = try XCTUnwrap(packageGraph.packages.first?.targets.map(\.underlyingTarget).first{ $0.name == "MyPlugin" } as? PluginTarget)
XCTAssertEqual(buildToolPlugin.name, "MyPlugin")
XCTAssertEqual(buildToolPlugin.capability, .buildTool)

Expand Down Expand Up @@ -873,7 +873,7 @@ class PluginInvocationTests: XCTestCase {
XCTAssert(packageGraph.packages.count == 1, "\(packageGraph.packages)")

// Find the build tool plugin.
let buildToolPlugin = try XCTUnwrap(packageGraph.packages[0].targets.map(\.underlyingTarget).filter{ $0.name == "X" }.first as? PluginTarget)
let buildToolPlugin = try XCTUnwrap(packageGraph.packages.first?.targets.map(\.underlyingTarget).filter{ $0.name == "X" }.first as? PluginTarget)
XCTAssertEqual(buildToolPlugin.name, "X")
XCTAssertEqual(buildToolPlugin.capability, .buildTool)

Expand Down Expand Up @@ -1203,7 +1203,7 @@ class PluginInvocationTests: XCTestCase {
XCTAssertNoDiagnostics(observability.diagnostics)

// Find the build tool plugin.
let buildToolPlugin = try XCTUnwrap(packageGraph.packages[0].targets
let buildToolPlugin = try XCTUnwrap(packageGraph.packages.first?.targets
.map(\.underlyingTarget)
.filter { $0.name == "Foo" }
.first as? PluginTarget)
Expand Down