Enable package visibility feature for tools-version 5.9 #6534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci smoke test |
MaxDesiatov
approved these changes
May 10, 2023
The package visibility proposal has officially been accepted: https://forums.swift.org/t/accepted-se-0386-package-access-modifier/64904 Resolves rdar://109152010
|
@swift-ci smoke test |
tomerd
changed the title
|
@swift-ci smoke test |
neonichu
reviewed
May 10, 2023
|
Should we add the flag to |
Co-authored-by: Boris Bügling <bbuegling@apple.com>
Looks like it was added for tools version 5.9 already in main; https://github.com/apple/swift-package-manager/blob/main/Sources/CompilerPluginSupport/TargetExtensions.swift#L23 |
|
@swift-ci smoke test |
elsh
changed the title
|
@swift-ci smoke test windows |
3 similar comments
|
@swift-ci smoke test windows |
|
@swift-ci smoke test windows |
|
@swift-ci smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package visibility proposal has officially been accepted: https://forums.swift.org/t/accepted-se-0386-package-access-modifier/64904
Resolves rdar://109152010